[Webkit-unassigned] [Bug 48799] Crash when dragging and dropping in a document with an invalid XHTML header

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48799





--- Comment #13 from MORITA Hajime <morrita at google.com>  2011-03-14 18:22:51 PST ---
(In reply to comment #12)
> (From update of attachment 85652 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85652&action=review
> 
> > LayoutTests/editing/pasteboard/drop-file-svg.html:23
> > +<p>PASS unless crash</p>
> 
> Nit: Please make this a full sentence.  Also, please mention that this test requires DRT.
> 
> > Source/WebCore/page/DragController.cpp:398
> > +    if (!m_page->dragCaretController()->isNone()) {
> > +        if (!dispatchTextInputEventFor(innerFrame, dragData))
> 
> Nit: Can we just combine these into 1 if statement using && ?

Hi Tony,
thank you for your quick review! 
I'll fix these before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.