[Webkit-unassigned] [Bug 48799] Crash when dragging and dropping in a document with an invalid XHTML header

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48799


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85652|review?                     |review+
               Flag|                            |




--- Comment #12 from Tony Chang <tony at chromium.org>  2011-03-14 10:18:25 PST ---
(From update of attachment 85652)
View in context: https://bugs.webkit.org/attachment.cgi?id=85652&action=review

> LayoutTests/editing/pasteboard/drop-file-svg.html:23
> +<p>PASS unless crash</p>

Nit: Please make this a full sentence.  Also, please mention that this test requires DRT.

> Source/WebCore/page/DragController.cpp:398
> +    if (!m_page->dragCaretController()->isNone()) {
> +        if (!dispatchTextInputEventFor(innerFrame, dragData))

Nit: Can we just combine these into 1 if statement using && ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.