[Webkit-unassigned] [Bug 56011] Tiled backing store's delegated scroll request uses incorrect convention

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56011





--- Comment #10 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-03-09 10:30:25 PST ---

> 
> Because of this:
> 
> http://trac.webkit.org/browser/trunk/Source/WebKit/qt/Api/qwebpage.cpp
> 4099        \fn void QWebPage::scrollRequested(int dx, int dy, const QRect& rectToScroll)
> 4100    
> 4101        This signal is emitted whenever the content given by \a rectToScroll needs
> 4102        to be scrolled \a dx and \a dy downwards and no view was set.
> 
> The docs imply to me that QWebPage::scrollRequested wants a delta, so I convert the point to the delta to match the expectations. I'm not sure about how the API is used today so perhaps it's the docs that need to be changed to say it's given a point =).

Ah this is for the WebKit1 port. Then that seems fine. I think we should rename this method for WebKit2 to scrollPositionRequested and use absolute values, otherwise we will have to convert twice for no sake.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.