[Webkit-unassigned] [Bug 56011] Tiled backing store's delegated scroll request uses incorrect convention

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56011





--- Comment #9 from Gustavo Noronha (kov) <gns at gnome.org>  2011-03-09 10:20:15 PST ---
(In reply to comment #8)
> (From update of attachment 85167 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85167&action=review
> 
> > Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:436
> > -    emit m_webPage->scrollRequested(delta.width(), delta.height(), QRect(QPoint(0, 0), m_webPage->viewportSize()));
> > +    QPoint currentPosition(m_webPage->mainFrame()->scrollPosition());
> > +    emit m_webPage->scrollRequested(point.x() - currentPosition.x(), point.y() - currentPosition.y(), QRect(QPoint(0, 0), m_webPage->viewportSize()));
> 
> This change

Because of this:

http://trac.webkit.org/browser/trunk/Source/WebKit/qt/Api/qwebpage.cpp
4099        \fn void QWebPage::scrollRequested(int dx, int dy, const QRect& rectToScroll)
4100    
4101        This signal is emitted whenever the content given by \a rectToScroll needs
4102        to be scrolled \a dx and \a dy downwards and no view was set.

The docs imply to me that QWebPage::scrollRequested wants a delta, so I convert the point to the delta to match the expectations. I'm not sure about how the API is used today so perhaps it's the docs that need to be changed to say it's given a point =).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.