[Webkit-unassigned] [Bug 55950] addInlineStyleIfNeeded should take EditingStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55950





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-08 11:57:56 PST ---
(In reply to comment #2)
> (From update of attachment 85068 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85068&action=review
> 
> > Source/WebCore/editing/ApplyStyleCommand.cpp:79
> > -    explicit StyleChange(CSSStyleDeclaration*, const Position&);
> > +    explicit StyleChange(EditingStyle*, const Position&);
> 
> It doesn’t make any sense to use the explicit keyword on a constructor that can’t be called with a single argument. So “explicit” should be removed here.

That's what I thought.  Okay, I'm getting rid of that.  Thanks for the review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.