[Webkit-unassigned] [Bug 55950] addInlineStyleIfNeeded should take EditingStyle

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 8 11:44:49 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=55950


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85068|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2011-03-08 11:44:49 PST ---
(From update of attachment 85068)
View in context: https://bugs.webkit.org/attachment.cgi?id=85068&action=review

> Source/WebCore/editing/ApplyStyleCommand.cpp:79
> -    explicit StyleChange(CSSStyleDeclaration*, const Position&);
> +    explicit StyleChange(EditingStyle*, const Position&);

It doesn’t make any sense to use the explicit keyword on a constructor that can’t be called with a single argument. So “explicit” should be removed here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list