[Webkit-unassigned] [Bug 55416] Viewport no longer allows an auto value for "user-scalable"

Tue Mar 8 00:57:57 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=55416

Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85015|review?                     |review+
               Flag|                            |

--- Comment #6 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-03-08 00:57:57 PST ---
(From update of attachment 85015)
View in context: https://bugs.webkit.org/attachment.cgi?id=85015&action=review

>> Source/WebCore/dom/ViewportArguments.cpp:175
>> +    if (args.userScalable == 0.0f)
> 
> Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]

Our coding style actually says to always use 0 and not .0 or .0f. (Section Floating point literals, item 1.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.