[Webkit-unassigned] [Bug 54179] Change text-based <input> types to use the new shadow DOM model

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54179


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84705|review?                     |review-
               Flag|                            |




--- Comment #6 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-03-04 10:57:54 PST ---
(From update of attachment 84705)
View in context: https://bugs.webkit.org/attachment.cgi?id=84705&action=review

Overall, I understand now why this patch is so large. I think it's fine to go with this, provided that we have green bubbles on EWS. But I hope this is not the end of it. Ideally, render objects shouldn't dip into shadow subtree to do layout calculations. Instead the render objects inside the shadow tree should provide this information to parent -- that's the way normal layout works.

> Source/WebCore/html/InputType.cpp:369
> +    shadowParent->parserAddChild(shadowChild);

What notification messages?

shadowParent->appendChild(shadowChild)

> Source/WebCore/html/SearchInputType.h:65
> +    RefPtr<TextControlInnerElement> m_innerBlock;
> +    RefPtr<SearchFieldResultsButtonElement> m_resultsButton;
> +    RefPtr<SearchFieldCancelButtonElement> m_cancelButton;

Do these need to be RefPtr?

> Source/WebCore/rendering/RenderTextControl.cpp:490
>  void RenderTextControl::forwardEvent(Event* event)
>  {
>      if (event->type() == eventNames().blurEvent || event->type() == eventNames().focusEvent)

Event forwarding should not be necessary now that shadowRoot is set properly.

> Source/WebCore/rendering/RenderTextControlMultiLine.cpp:110
> +/* $$$ remove

Probably didn't mean to leave this in.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.