[Webkit-unassigned] [Bug 54179] Change text-based <input> types to use the new shadow DOM model

Fri Mar 4 07:20:15 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=54179

--- Comment #5 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-03-04 07:20:15 PST ---
(In reply to comment #3)
> Some notes on the work-in-progress patch:
> 
> .) It also includes type=search (hence the renaming of this bug entry), but search should really have it's own RenderTextControl sub-type.
> 
> .) The shadow DOM objects are so far largely unchanged from the original code. Layouting is still handled by the RenderTExtControlSingleLine. If possible, I would keep this arrangement for the initial version, and move the layouting logic to the shadow Elements in subsequent bugs/patches.
> 
> .) There is some inefficiency that the shadow DOM for type=text is created by default, then destroyed and overwritten once the type attribute is read. Not sure how we can fix this (or whether it really matters).

I am concerned that the patch is so large. Can it be broken into smaller pieces?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.