[Webkit-unassigned] [Bug 55719] [Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55719


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84703|review?                     |review-
               Flag|                            |




--- Comment #4 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-03-04 00:32:41 PST ---
(From update of attachment 84703)
View in context: https://bugs.webkit.org/attachment.cgi?id=84703&action=review

Where are the changelogs? Did you run check-webkit-style and prepare-ChangeLog? Please consult the wikipages on how to contribute to WebKit

> Source/WebKit.pri:76
> +webkit2:INCLUDEPATH *= $$OUTPUT_DIR/include/WebKit2 $$OUTPUT_DIR/WebKit2/generated

Don't we have these generated included somewhere else?

> Source/WebKit2/PluginProcess/PluginControllerProxy.cpp:258
> +#if PLATFORM(MAC)
>  void PluginControllerProxy::setComplexTextInputEnabled(bool complexTextInputEnabled)

So we will not support input methods? Actuallu you are saying that no other platform that Mac will support this. I guess this should be #if !PLATFORM(QT) instead

> Source/WebKit2/PluginProcess/PluginProcess.cpp:133
>  
>  void PluginProcess::createWebProcessConnection()
>  {
> +#if PLATFORM(MAC)
>      // FIXME: This is platform specific!

Maybe this should be integrated into a PluginProcessMac instead?

> Source/WebKit2/Scripts/webkit2/messages.py:454
> +    headers = {
> +        '"%s"' % messages_header_filename(receiver): None,
> +        '"HandleMessage.h"': None,

This patch is very hard to review as there is no changelog explaining why you are making these changes...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.