[Webkit-unassigned] [Bug 55717] On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55717





--- Comment #4 from jpu at apple.com  2011-03-03 19:33:19 PST ---
(In reply to comment #2)
> (From update of attachment 84642 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84642&action=review
> 
> > Source/WebCore/ChangeLog:28
> > +        * manual-tests/platforms/mac/autocorrection/autocorreciton-in-iframe.html: Added.
> 
> Typo in filename here: autocorreciton
> 
> > Source/WebCore/editing/Editor.cpp:2407
> > +                    IntRect boundingBoxInWindow = frame()->view()->contentsToWindow(IntRect(boundingBox));
> 
> Can frame() or view() ever be 0 here? Same question for the other places this appears.

Judging by the fact that there are many calls to frame() without checking. I assume it's safe. We could put an assertion.  I will check the return value of view(). My thought is not to litter the code with unnecessary check of this sort.
> 
> I think you should make a helper function in this class that returns the boundingBoxInWindow for a Range because this idiom is repeated three different times in this file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.