[Webkit-unassigned] [Bug 55717] On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55717





--- Comment #3 from jpu at apple.com  2011-03-03 17:05:36 PST ---
(In reply to comment #2)
> (From update of attachment 84642 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84642&action=review
> 
> Seems good. Almost right for landing, but I’d like you to at least rename Range::getBoundingRect and possibly split this up into more than once patch.
> 
> > Source/WebCore/ChangeLog:17
> > +        2. Moved all Mac-only manuel test into manual-tests/platform/mac directory.
> 
> Typo here: "manuel".
> 
> I know that our automated tests use the path platforms/mac, but I’m not sure it’s great for the manual tests. I guess it’s OK, but the extra level of hierarchy seems annoying. These already were in a directory named autocorrection. I’m not sure we needed to move them at all.

I just want to be clear that they're all mac-only tests. If you think it's OK as it is, I will pull them out.

> 
> > Source/WebCore/ChangeLog:18
> > +        3. Cleaned up code in Editor::removeSpellAndCorrectionMarkersFromWordsToBeEdited().
> 
> Could you land this in a separate patch? Is there some reason to combine these?

I can certainly put this in separate patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.