[Webkit-unassigned] [Bug 55440] improve layout performance by reducing the traversal time of the floating objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55440





--- Comment #13 from Yuqiang Xian <yuqiang.xian at intel.com>  2011-03-03 18:46:54 PST ---
Thanks for the reivew.

(In reply to comment #12)
> (From update of attachment 84677 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84677&action=review
> 
> > Source/WebCore/rendering/RenderBlock.h:729
> > +        FloatingObjectSet* set() const { return m_set.get(); }
> 
> Would be better to return a reference to the set instead of a pointer. Also no reason for this to be const.

OK. Will modify it.

> 
> > Source/WebCore/rendering/RenderBlock.h:732
> > +        OwnPtr<FloatingObjectSet> m_set;
> 
> Why did you chose to use an OwnPtr here instead of just putting the set in? This should just be:
> 
>     FloatingObjectSet m_set;
> 

As the original code uses the FloatingObjectSet as an OwnPtr and I didn't want to change that. But yes it can be just an instance inside. Will modify it.

> > Source/WebCore/rendering/RenderBlock.h:734
> > +        unsigned int m_leftObjectsCount;
> > +        unsigned int m_rightObjectsCount;
> 
> Should just be unsigned, not unsigned int, given WebKit coding style.

Will modify it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.