[Webkit-unassigned] [Bug 55440] improve layout performance by reducing the traversal time of the floating objects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 3 18:36:40 PST 2011


--- Comment #12 from Darin Adler <darin at apple.com>  2011-03-03 18:36:40 PST ---
(From update of attachment 84677)
View in context: https://bugs.webkit.org/attachment.cgi?id=84677&action=review

> Source/WebCore/rendering/RenderBlock.h:729
> +        FloatingObjectSet* set() const { return m_set.get(); }

Would be better to return a reference to the set instead of a pointer. Also no reason for this to be const.

> Source/WebCore/rendering/RenderBlock.h:732
> +        OwnPtr<FloatingObjectSet> m_set;

Why did you chose to use an OwnPtr here instead of just putting the set in? This should just be:

    FloatingObjectSet m_set;

> Source/WebCore/rendering/RenderBlock.h:734
> +        unsigned int m_leftObjectsCount;
> +        unsigned int m_rightObjectsCount;

Should just be unsigned, not unsigned int, given WebKit coding style.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list