[Webkit-unassigned] [Bug 55644] [fileapi] Add URI resolution support to WorkerContext

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 3 12:09:45 PST 2011


--- Comment #4 from Adam Klein <adamk at chromium.org>  2011-03-03 12:09:45 PST ---
(From update of attachment 84508)
View in context: https://bugs.webkit.org/attachment.cgi?id=84508&action=review

>> Source/WebKit/chromium/src/LocalFileSystemChromium.cpp:60
>> +void LocalFileSystem::readFileSystem(ScriptExecutionContext* context, AsyncFileSystem::Type type, PassOwnPtr<AsyncFileSystemCallbacks> callbacks, bool synchronous)
> The implementation of this method is mostly same as that of requestFileSystem-- maybe we could factor out a common private method that takes all of parameters plus boolean create flag and make both readFileSystem and requestFileSystem a wrapper of the method.

Good idea.  I've done that.  The only thing that I don't like about all this is the fact that there's two bools and a long long all together in one signature.  Quite easy to screw up the order and break stuff.  I'd like to come back to this code and redo the API with enums instead.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list