[Webkit-unassigned] [Bug 55644] [fileapi] Add URI resolution support to WorkerContext

Wed Mar 2 23:08:05 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=55644

--- Comment #3 from Kinuko Yasuda <kinuko at chromium.org>  2011-03-02 23:08:05 PST ---
(From update of attachment 84508)
View in context: https://bugs.webkit.org/attachment.cgi?id=84508&action=review

lgtm.

> Source/WebKit/chromium/src/LocalFileSystemChromium.cpp:60
> +void LocalFileSystem::readFileSystem(ScriptExecutionContext* context, AsyncFileSystem::Type type, PassOwnPtr<AsyncFileSystemCallbacks> callbacks, bool synchronous)

The implementation of this method is mostly same as that of requestFileSystem-- maybe we could factor out a common private method that takes all of parameters plus boolean create flag and make both readFileSystem and requestFileSystem a wrapper of the method.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.