[Webkit-unassigned] [Bug 54969] [Chromium] Implement WebKit methods to assist with Cocoa NSTextInput implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54969





--- Comment #6 from Robert Sesek <rsesek at chromium.org>  2011-03-01 12:16:21 PST ---
(From update of attachment 83828)
View in context: https://bugs.webkit.org/attachment.cgi?id=83828&action=review

>>> Source/WebKit/chromium/src/WebFrameImpl.cpp:2298
>>> +// This function is copied from /WebKit2/WebPage/mac/WebPageMac.mm.
>> 
>> Sounds like this should just live in WebCore. There's nothing WebKitty here. Can you move and unduplicate?
> 
> These could probably go to Source/WebCore/platform/text/mac?
> 
> Sam, Enrica do you guys have any opinions?

I've moved this function to be Frame::rangeForPoint(), which fits well with documentAtPoint() and visiblePositionForPoint(). Other platforms may need this for their text input systems.

>>> Source/WebKit/chromium/src/WebFrameImpl.cpp:2325

>> 
>> Ditto.
> 
> 

Moved this to Range::getLocationAndLength().

>> Source/WebKit/chromium/src/mac/WebTextHelper.mm:74
>> +// This function is copied from /WebKit/mac/Misc/WebNSAttributedStringExtras.mm.
> 
> Can we just compile WebNSAttributedStringExtras.mm?

We can't use it directly because WebKit/mac uses <WebCore/x.h> for #include and WebKit/chromium uses "x.h". Could I move WebNSAttributedStringExtras.{h,mm} wholesale into WebCore/platform/text/mac?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.