[Webkit-unassigned] [Bug 54969] [Chromium] Implement WebKit methods to assist with Cocoa NSTextInput implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54969


Dimitri Glazkov (Google) <dglazkov at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |enrica at apple.com,
                   |                            |sam at webkit.org




--- Comment #5 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-03-01 08:49:08 PST ---
(In reply to comment #4)
> (From update of attachment 83828 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83828&action=review
> 
> Pls fix EWS breakage and help to unduplicate.
> 
> > Source/WebKit/chromium/src/WebFrameImpl.cpp:2298
> > +// This function is copied from /WebKit2/WebPage/mac/WebPageMac.mm.
> 
> Sounds like this should just live in WebCore. There's nothing WebKitty here. Can you move and unduplicate?

These could probably go to Source/WebCore/platform/text/mac?

Sam, Enrica do you guys have any opinions?

> 
> > Source/WebKit/chromium/src/WebFrameImpl.cpp:2325
> > +bool WebFrameImpl::getLocationAndLengthFromRange(Range* range, unsigned& location, unsigned& length) const
> 
> Ditto.
> 
> > Source/WebKit/chromium/src/mac/WebTextHelper.mm:74
> > +// This function is copied from /WebKit/mac/Misc/WebNSAttributedStringExtras.mm.
> 
> Can we just compile WebNSAttributedStringExtras.mm?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.