[Webkit-unassigned] [Bug 63706] [GTK] Implement drag and drop support in WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63706





--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-06-30 09:11:42 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> 
> > > >> Source/WebKit2/Shared/gtk/ArgumentCodersGtk.cpp:113
> > > >> +static bool decodeDataObject(ArgumentDecoder* decoder, RefPtr<DataObjectGtk>& dataObject)
> > > > 
> > > > The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
> > > 
> > > It's pretty weird to pass a reference to a RefPtr here. You should just use a PassRefPtr.
> > 
> > See decodeImage in Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:
> > static bool decodeImage(ArgumentDecoder* decoder, RefPtr<Image>& image)
> 
> WebKit as a project has recently become more strict about RefPtr/PassRefPtr usage. Perhaps there was some reason it wasn't possible in that case, but my instinct says this should just be a PassRefPtr.

Ok, I'll look at it again to try to use a PassRefPtr instead, thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.