[Webkit-unassigned] [Bug 63395] [WebKit2] Add logging initialization for WebProcess

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63395





--- Comment #3 from Lukasz Slachciak <l.slachciak at samsung.com>  2011-06-30 01:03:32 PST ---
(From update of attachment 98619)
View in context: https://bugs.webkit.org/attachment.cgi?id=98619&action=review

Leaonardo, I generally agree with you that there is a lot of logging inconsistency in WebKit. There is no ENABLE(LOGGING) feature.
I started some time a go discussion about it: https://lists.webkit.org/pipermail/webkit-dev/2011-June/017278.html
I'm planning to continue to do logging cleanup in WebKit (and propose new patches).
But this what I would like to do in this bug - just to enable logging following current schemes and standard, so I can fully utilize it in WebKit2.

>> Source/WebKit2/ChangeLog:8
>> +        Logging initialization was added for WebProcess. Similar initialization is already done for UIProcess.
> 
> Watch out for 80-column limit on changelogs.

Ok, I'll fix this

>> Source/WebKit2/WebProcess/WebProcess.cpp:143
>> +#if !LOG_DISABLED
> 
> I haven't seen this idiom lately on WebKit -- wouldn't it be better if it were an ENABLE(LOGGING) macro call?

In mac port it is commonly used in Webkit and WebKit2, using ENABLE(LOGGING) would require defining LOGGING feature in Platform.h
in WebCore it is commonly used.
grep -r "\!LOG_DISABLED" Source/ | wc -l
shows me 89 occurences

>> Source/WebKit2/WebProcess/WebProcess.cpp:147
>>      WebCore::InitializeLoggingChannelsIfNecessary();
> 
> A couple of questions here:
> 
> 1) Shouldn't the LOG_DISABLED macro also disable WebCore's initialization?
> 2) Why are WebKit's and WebCore's log channel initialization functions are named differently ('Log' vs. 'Logging')?
> 3) Also, unrelated to this patch, looks like WebCore's method is wrongly named (begins with a capital letter).

1) I was following original WebKit2 design as in case of Source/WebKit2/UIProcess/WebContext.cpp
 where WebProcess is initialized - WebKit logging initialization depends on the LOG_DISABLED macro while WebCore logging initialization doesn't depend on it.
In fact in the Source/WebKit WebCore logging initialization is also not depending on the LOG_DISABLED
2) I think that it was code author's invention
3) dito

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.