[Webkit-unassigned] [Bug 63494] REGRESSION(r84294): new-run-webkit-tests results.html generate links to diffs.html or diff.png that don't exist

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63494





--- Comment #6 from Dirk Pranke <dpranke at chromium.org>  2011-06-29 17:12:36 PST ---
(In reply to comment #5)
> (In reply to comment #3)
> > On further investigation (e.g., fast/box-shadow/basic-shadows.html), we're getting cases where the checksums don't match but the images do match, as reported by ImageDiff.
> 
> Hm. That should not happen now that checksums are embedded in pngs!
> 

Tony pointed out a difference a week or two ago where the apple mac ImageDiff implementation will report some PNGs as identical even when they are not bit-for-bit identical (i.e., even when --tolerance=0.0 is specified).

I think that that's a bug in ImageDiff that should be fixed, but perhaps that is debatable. Regardless, that is probably what is causing this.

> The right solution IMO, is to make the results types serialized to the JSON file have a one-to-one mapping with the TestFailure types. That would also help cleanup code.

That would probably work, and certainly simplify some things.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.