[Webkit-unassigned] [Bug 63494] REGRESSION(r84294): new-run-webkit-tests results.html generate links to diffs.html or diff.png that don't exist

Wed Jun 29 16:54:57 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=63494

Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tony at chromium.org

--- Comment #5 from Ojan Vafai <ojan at chromium.org>  2011-06-29 16:54:57 PST ---
(In reply to comment #3)
> On further investigation (e.g., fast/box-shadow/basic-shadows.html), we're getting cases where the checksums don't match but the images do match, as reported by ImageDiff.

Hm. That should not happen now that checksums are embedded in pngs!

> So, no -diff files will be created. However, the test is still reported as failing. I think the json results generator doesn't know how to distinguish the different kinds of failures, and so it reports the generic Image failure.
> 
> We might need to add another flag to the test_dict in manager.py: summarize_results() to handle this case.
> 
> Once again, the attempt to map the broader set of TestFailures onto the smaller set of expectation types might be hurting us.

The right solution IMO, is to make the results types serialized to the JSON file have a one-to-one mapping with the TestFailure types. That would also help cleanup code.

(In reply to comment #4)
> Is someone stepping up to own this issue.  Ojan?

I won't realistically get to it anytime soon.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.