[Webkit-unassigned] [Bug 63471] Extract LineBreakIteratorPool class into its own file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63471


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com




--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org>  2011-06-27 13:43:30 PST ---
(In reply to comment #4)
> (From update of attachment 98763 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98763&action=review
> 
> > Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:2
> > + * Copyright (C) 2006 Lars Knoll <lars at trolltech.com>
> 
> Lars shouldn’t get copyright for this new code.
> 
> > Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:3
> > + * Copyright (C) 2007 Apple Inc. All rights reserved.
> 
> The code you put into this file is all new. The copyright should be 2011, not 2007.

Wow, I didn't realize how new it was! That sounds good.
http://trac.webkit.org/changeset/89592


> > Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:34
> > +WTF_MAKE_NONCOPYABLE(LineBreakIteratorPool);
> 
> I think this should be indented.

Okay, will fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.