[Webkit-unassigned] [Bug 63471] Extract LineBreakIteratorPool class into its own file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63471


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98763|review?                     |review+
               Flag|                            |




--- Comment #4 from Darin Adler <darin at apple.com>  2011-06-27 12:35:07 PST ---
(From update of attachment 98763)
View in context: https://bugs.webkit.org/attachment.cgi?id=98763&action=review

> Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:2
> + * Copyright (C) 2006 Lars Knoll <lars at trolltech.com>

Lars shouldn’t get copyright for this new code.

> Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:3
> + * Copyright (C) 2007 Apple Inc. All rights reserved.

The code you put into this file is all new. The copyright should be 2011, not 2007.

> Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:34
> +WTF_MAKE_NONCOPYABLE(LineBreakIteratorPool);

I think this should be indented.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.