[Webkit-unassigned] [Bug 63194] TestFailures page should show closed bugs, too

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63194





--- Comment #3 from Adam Roben (:aroben) <aroben at apple.com>  2011-06-23 08:16:36 PST ---
(From update of attachment 98353)
View in context: https://bugs.webkit.org/attachment.cgi?id=98353&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:238
>> +            list.appendChildren(openBugs.map(bugToListItem));
> 
> What if all the bugs found are closed?  Shouldn't you check if openBugs.length here, or is that checked above?
> 
>     if (openBugs.length)
>         list.appendChildren(openBugs.map(bugToListItem));

If openBugs is an empty array, then the appendChildren call will do nothing, which is what we want. (The only reason we check closedBugs.length below is to avoid adding the "Closed bugs:" list item if there are no closed bugs.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.