[Webkit-unassigned] [Bug 63194] TestFailures page should show closed bugs, too

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63194


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #98353|review?                     |review+
               Flag|                            |




--- Comment #2 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2011-06-23 08:15:22 PST ---
(From update of attachment 98353)
View in context: https://bugs.webkit.org/attachment.cgi?id=98353&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:238
> +            list.appendChildren(openBugs.map(bugToListItem));

What if all the bugs found are closed?  Shouldn't you check if openBugs.length here, or is that checked above?

    if (openBugs.length)
        list.appendChildren(openBugs.map(bugToListItem));

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.