[Webkit-unassigned] [Bug 62628] [EFL] Crash when running EWebLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62628





--- Comment #23 from Raphael Kubo da Costa <kubo at profusion.mobi>  2011-06-22 07:03:03 PST ---
(In reply to comment #22)
> (In reply to comment #21)
> > Created an attachment (id=98089)
 --> (https://bugs.webkit.org/attachment.cgi?id=98089&action=review) [details] [details]
> > Patch
> 
> I prepared patch instead of Michal after discussed.

Please mark Michal's patch as obsolete then.

> All of other ports call setEncoding in FrameLoderClient::finishedLoading() to remove document and clear parser, but WebKit/EFL didn't.

Unfortunately the other ports don't say much about why it has been done this way: it was introduced in chromium in revision 50742 which just upstreamed a lot of code, in qt in revision 67268 which just copied chromium's behaviour to fix some tests and in gtk in revision 77596 due to unrelated reasons.

The same patch was part of code we were going to upstream with EFL's DumpRenderTree anyway. If it also fixes this crash, I'm all for it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.