[Webkit-unassigned] [Bug 62628] [EFL] Crash when running EWebLauncher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62628





--- Comment #22 from Ryuan Choi <ryuan.choi at samsung.com>  2011-06-21 18:03:05 PST ---
(In reply to comment #21)
> Created an attachment (id=98089)
 --> (https://bugs.webkit.org/attachment.cgi?id=98089&action=review) [details]
> Patch

I prepared patch instead of Michal after discussed.
All of other ports call setEncoding in FrameLoderClient::finishedLoading() to remove document and clear parser, but WebKit/EFL didn't.

With this patch, this crash will be passed.

BTW, I don't know endIfNotLoadingMainResource should check isLoadingMainResource() which already set false in caller().
Only DocumentWriter::end() call endIfNotLoadingMainResource().

void DocumentWriter::end()
{
    m_frame->loader()->didEndDocument(); // <- set m_isLoadingMainResource to false.
    endIfNotLoadingMainResource();
}

void DocumentWriter::endIfNotLoadingMainResource()
{
    if (m_frame->loader()->isLoadingMainResource() || !m_frame->page() || !m_frame->document())
        return;
...
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.