[Webkit-unassigned] [Bug 63004] [Qt] Regression(60942) wrong default action for drag-and-drop.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63004





--- Comment #3 from Yael <yael.aharon at nokia.com>  2011-06-20 14:13:38 PST ---
(In reply to comment #2)
> It would be great to have a LayoutTest specially because you said in ChangeLog:
> "Call event->accepted() and not event->acceptProposedAction(), because the later ignores the dropAction specified in JavaScript."
> This behavior should be testable in LayoutTests.
> (In reply to comment #1)
> > Created an attachment (id=97836)
 --> (https://bugs.webkit.org/attachment.cgi?id=97836&action=review) [details] [details]
> > Patch.
> > 
> > Added special handling for the case that dragOperation is not initialized.
> > Save the last dropOperation and pass it to the dropEvent, so that it can be accepted by QDrag.
> > Call event->accepted() and not event->acceptProposedAction(), because the later ignores the dropAction specified in JavaScript.
> > 
> > Tested with the test page attached to https://bugs.webkit.org/show_bug.cgi?id=40401 and did not see any issue.
> > Also manually tested all combinations of LayoutTests/fast/events/drag-and-drop.html and they all pass.

Yes, it would have been great to have a layout test.
Please see https://bugs.webkit.org/show_bug.cgi?id=31332#c7 why I do not have one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.