[Webkit-unassigned] [Bug 63004] [Qt] Regression(60942) wrong default action for drag-and-drop.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63004


Igor Trindade Oliveira <itrindade.oliveira at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |itrindade.oliveira at gmail.co
                   |                            |m




--- Comment #2 from Igor Trindade Oliveira <itrindade.oliveira at gmail.com>  2011-06-20 13:07:02 PST ---
It would be great to have a LayoutTest specially because you said in ChangeLog:

"Call event->accepted() and not event->acceptProposedAction(), because the later ignores the dropAction specified in JavaScript."

This behavior should be testable in LayoutTests.

(In reply to comment #1)
> Created an attachment (id=97836)
 --> (https://bugs.webkit.org/attachment.cgi?id=97836&action=review) [details]
> Patch.
> 
> Added special handling for the case that dragOperation is not initialized.
> Save the last dropOperation and pass it to the dropEvent, so that it can be accepted by QDrag.
> Call event->accepted() and not event->acceptProposedAction(), because the later ignores the dropAction specified in JavaScript.
> 
> Tested with the test page attached to https://bugs.webkit.org/show_bug.cgi?id=40401 and did not see any issue.
> Also manually tested all combinations of LayoutTests/fast/events/drag-and-drop.html and they all pass.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.