[Webkit-unassigned] [Bug 62961] [EFL] Add GraphicsContext3DInternal implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62961





--- Comment #9 from Ryuan Choi <ryuan.choi at samsung.com>  2011-06-20 03:45:19 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=97769&action=review

> Source/WebCore/platform/graphics/efl/GraphicsContext3DInternal.cpp:59
> +    Evas_Object* ewkView = static_cast<Evas_Object*>(hostWindow->platformPageClient());

how do you think view instead of ewkView.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DInternal.cpp:70
> +    Evas_GL_Context* shareContext = 0;

shareContext or sharedContext? Which one is right?

> Source/WebCore/platform/graphics/efl/GraphicsContext3DInternal.cpp:74
> +        GraphicsContext3D* compositingContext = ewk_view_accelerated_compositing_context_get(ewkView);

Is it public api?
If not, does we need to guard this to ACCELEARTED_COMPOSITING macro?

> Source/WebCore/platform/graphics/efl/GraphicsContext3DInternal.cpp:89
> +bool GraphicsContext3DInternal::createSurface(Evas_Object* ewkView, bool renderDirectlyToEvasGLObject)

If createSurface is only for initialize, does we need to separate it?

> Source/WebCore/platform/graphics/efl/GraphicsContext3DInternal.cpp:98
> +    evas_object_geometry_get(ewkView, &x, &y, &w, &h);

I think that we can move this into if (renderDirectlyToEvasGLObject).
And evas_object_geometry_get will clear values to 0 although it failed.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DInternal.cpp:100
> +    int surfaceWidth = 0, surfaceHeight = 0;

I prefered these meaningful name, but can we share this with w, h.

> Source/WebCore/platform/graphics/efl/GraphicsContext3DInternal.cpp:106
> +    } else
> +        surfaceWidth = surfaceHeight = 1;

How about initializing above values to 1 instead of else statement.

Other codes looks just bypassed from WebKit's to evas_gl_api's.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.