[Webkit-unassigned] [Bug 62961] [EFL] Add GraphicsContext3DInternal implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62961





--- Comment #6 from Ryuan Choi <ryuan.choi at samsung.com>  2011-06-20 00:31:36 PST ---
(In reply to comment #2)
> View in context: https://bugs.webkit.org/attachment.cgi?id=97734&action=review
> 
> > Source/WebCore/platform/graphics/efl/GraphicsContext3DInternal.cpp:61
> > +    m_evasGL = ewk_view_evas_gl_create(ewkView);
> 
> Should we call ewk api to create evas GL?
> 
> > Source/WebCore/platform/graphics/efl/GraphicsContext3DInternal.cpp:83
> > +    m_context = evas_gl_context_create(m_evasGL, shareContext);
> > +    if (!m_context)
> > +        return false;
> > +
> > +    if (!createSurface(ewkView, bRenderDirectlyToEvasGLObject))
> > +        return false;
> 
> If we can fail to create here, I think that we should create evas gl.
> Is it right?

s/create evas gl/clear evas gl/
anyway, this is my mistake after discussed. please ignore it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.