[Webkit-unassigned] [Bug 62730] Python checks for sys.platform have to be relaxed and/or extended for Linux >=3.0-rc1 support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 15 21:14:29 PDT 2011


--- Comment #12 from Torsten <gentoo at tk-webart.de>  2011-06-15 21:14:29 PST ---
(In reply to comment #11)
> Overall I think this change is fine.  I think it could be made better by just removign a bunch of these unneeded sys.platform checks instead, as I describe below.
> > Tools/Scripts/webkitpy/common/system/executive.py:278
> > +        if sys.platform.startswith('linux') or sys.platform in ('darwin', 'cygwin'):
> This can just be removed and made into a ! win32 branch.  We don't need ot fall-through to an assert, we can just assume win32 is the only crazy one.

Hmm, so what about derivates, like mingw32? I'd like to be as general as possible, too, but can we really be sure, there aren't any oddities, except for win32?

> > Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:507
> > +        while ((directory != 'http' or sys.platform == 'darwin' or sys.platform.startswith('linux'))
> No, we should just check options.use_apache somewhere.  We shouldn't be copying the use_apache check here.

Can you explain this in more detail, please? I didn't see any part of WebKit's code until the day before yesterday, so I'm still a bit lost therein. ;-)


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list