[Webkit-unassigned] [Bug 62730] Python checks for sys.platform have to be relaxed and/or extended for Linux >=3.0-rc1 support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 15 16:32:12 PDT 2011


--- Comment #11 from Eric Seidel <eric at webkit.org>  2011-06-15 16:32:12 PST ---
(From update of attachment 97322)
View in context: https://bugs.webkit.org/attachment.cgi?id=97322&action=review

Overall I think this change is fine.  I think it could be made better by just removign a bunch of these unneeded sys.platform checks instead, as I describe below.

> Tools/Scripts/webkitpy/common/system/executive.py:278
> +        if sys.platform.startswith('linux') or sys.platform in ('darwin', 'cygwin'):

This can just be removed and made into a ! win32 branch.  We don't need ot fall-through to an assert, we can just assume win32 is the only crazy one.

> Tools/Scripts/webkitpy/common/system/file_lock.py:46
> +        if sys.platform.startswith('linux') or sys.platform in ('darwin', 'cygwin'):

Again we just want a !win32 branch.

> Tools/Scripts/webkitpy/common/system/file_lock.py:54
> +        if sys.platform.startswith('linux') or sys.platform in ('darwin', 'cygwin'):


> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:153
> +        options.use_apache = sys.platform.startswith('linux') or sys.platform == 'darwin'

This seems reasonable.  Perhaps we should be moving to a platform.system() check, but this is also OK as is.

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:507
> +        while ((directory != 'http' or sys.platform == 'darwin' or sys.platform.startswith('linux'))

No, we should just check options.use_apache somewhere.  We shouldn't be copying the use_apache check here.

> Tools/Scripts/webkitpy/layout_tests/port/chromium_gpu.py:44
> +        elif platform.startswith('linux'):

Seems reasonable.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list