[Webkit-unassigned] [Bug 62630] [Qt] Fix the build with gcc 4.6 after r88712

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62630





--- Comment #1 from Csaba Osztrogonac <ossy at webkit.org>  2011-06-14 05:15:32 PST ---
(In reply to comment #0)
> http://trac.webkit.org/changeset/88712 revealed a dead variable:
> 
> Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:135:10: error: variable 'forceCarbon' set but not used [-Werror=unused-but-set-variable]
> 
> The forceCarbon variable is initialized false in the common code-path, then checked in a section guarded by XP_MACOSX:
> 
> Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:168:    if (supportsCocoa && !forceCarbon)
> 
> and then set to true in Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:218
> 
>         else if (strcasecmp(argn[i], "forcecarbon") == 0)
>             forceCarbon = true;
> 
> Since forceCarbon is always false in main.cpp:168 it is irrelevant in this function and can be removed.

I agree.

Additionally setting forceCarbon to true in main.cpp:219 is dead code,
because its value isn't used after this line. It should be removed too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.