[Webkit-unassigned] [Bug 62630] New: [Qt] Fix the build with gcc 4.6 after r88712

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 14 05:12:28 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=62630

           Summary: [Qt] Fix the build with gcc 4.6 after r88712
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: Linux
            Status: NEW
          Keywords: Qt, QtTriaged
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: abecsi at webkit.org
                CC: eric at webkit.org, ossy at webkit.org, mrobinson at webkit.org


http://trac.webkit.org/changeset/88712 revealed a dead variable:

Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:135:10: error: variable 'forceCarbon' set but not used [-Werror=unused-but-set-variable]

The forceCarbon variable is initialized false in the common code-path, then checked in a section guarded by XP_MACOSX:

Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:168:    if (supportsCocoa && !forceCarbon)

and then set to true in Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp:218

        else if (strcasecmp(argn[i], "forcecarbon") == 0)
            forceCarbon = true;

Since forceCarbon is always false in main.cpp:168 it is irrelevant in this function and can be removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list