[Webkit-unassigned] [Bug 56935] [Qt] Implement accelerated compositing on WK2 Qt port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 13 08:37:59 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=56935





--- Comment #18 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-06-13 08:37:59 PST ---
(In reply to comment #16)
> (In reply to comment #15)
> > > > Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h:67
> > > > +    void pauseAnimation(const String& /*animationName*/, double /*timeOffset*/);
> > > 
> > > this is a header, please just write animationName and leave out the /* */s
> > 
> > I'm sorry, but check-webkit-style script insists on not having parameter names in .h files - just parameter types. Removing /* */ will make it cry ;)
> 
> Well it should be fixed then, as that should be totally ok in header files. Also the script is just educational.
> 
> Or did our style guide change?
These function defs are actually directly copied from GraphicsLayer.h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list