[Webkit-unassigned] [Bug 56935] [Qt] Implement accelerated compositing on WK2 Qt port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=56935





--- Comment #17 from Noam Rosenthal <noam.rosenthal at nokia.com>  2011-06-13 08:37:11 PST ---
(In reply to comment #13)
> (From update of attachment 96896 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96896&action=review
> 
> > Source/WebKit2/Shared/WebLayerTreeInfo.cpp:36
> > +    encoder->encode(CoreIPC::In(id, name, parent, children, flags, replica, mask));
> > +    encoder->encode(CoreIPC::In(pos, size, transform, opacity, anchorPoint, childrenTransform, contentsRect));
> 
> Any reason why these are encoded separately?
You can't encode more than 10 arguments.

> 
> > Source/WebKit2/Shared/WebLayerTreeInfo.h:58
> > +    FloatPoint pos;
> 
> Dont we normally use location() in WebCore ?
No, we use pos. See GraphicsLayer.h

> 
> > Source/WebKit2/Shared/WebLayerTreeInfo.h:64
> > +    FloatSize size;
> > +    TransformationMatrix transform;
> > +    TransformationMatrix childrenTransform;
> > +    IntRect contentsRect;
> > +    float opacity;
> 
> how is size different from contentsRect.size() ?
Very different. A layer with a directly composited image can show an image at 10,10,20,20, but clip its children to 0,0,100,100.

> 
> > Source/WebKit2/Shared/WebLayerTreeInfo.h:86
> > +    Vector<WebLayerInfo> layers;
> > +    Vector<WebLayerID> deletedLayers;
> 
> Both are called layers, though one is a vector of layer ids and the one of of layer infos. A bit confusing

OK, will modify to deletedLayerIDs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.