[Webkit-unassigned] [Bug 62194] new-run-webkit-tests: 'images' links on results.html don't work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62194





--- Comment #6 from Dirk Pranke <dpranke at chromium.org>  2011-06-10 16:01:20 PST ---
(In reply to comment #3)
> Created an attachment (id=96808)
 --> (https://bugs.webkit.org/attachment.cgi?id=96808&action=review) [details]
> fixes the bug
> 
> I don't know if I should be adding a test or where I should be adding a test since test_result_writer.py doesn't seem to have any tests.

Hm. That's a bit odd. Feel free to start writing some in a test_result_writer_unittest.py class, but I probably wouldn't R- you for this.

(In reply to comment #5)
> (From update of attachment 96808 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96808&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:119
> > +    def output_filename(self, modifier, local=False):
> 
> I'd rather you just create an output_testname method. I think that results in better self-documenting code.

Agreed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.