[Webkit-unassigned] [Bug 62194] new-run-webkit-tests: 'images' links on results.html don't work

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 10 15:51:26 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=62194


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96808|review?                     |review-
               Flag|                            |




--- Comment #5 from Ojan Vafai <ojan at chromium.org>  2011-06-10 15:51:26 PST ---
(From update of attachment 96808)
View in context: https://bugs.webkit.org/attachment.cgi?id=96808&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:119
> +    def output_filename(self, modifier, local=False):

I'd rather you just create an output_testname method. I think that results in better self-documenting code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list