[Webkit-unassigned] [Bug 62345] [V8][Chromium] Use per-isolate embedder data instead of statics for caches in bindings
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 9 12:08:54 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=62345
--- Comment #5 from Dmitry Lomov <dslomov at google.com> 2011-06-09 12:08:54 PST ---
(From update of attachment 96525)
View in context: https://bugs.webkit.org/attachment.cgi?id=96525&action=review
>> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2206
>> + data->rawTemplateMap().find(&info);
>
> One line pls.
Thanks - will fix. I should also update example generation results in bindings/scripts/test - then the style checker would have caught me.
>> Source/WebCore/bindings/v8/V8Binding.cpp:72
>> + delete static_cast<V8BindingPerIsolateData*>(data);
>
> This pattern is really ugly.
What is ugly? How would you write this instead?
>> Source/WebCore/bindings/v8/V8Binding.cpp:595
>> + v8::Persistent<v8::FunctionTemplate>& toStringTemplate = V8BindingPerIsolateData::current()->toStringTemplate();
>
> Using a reference here is very subtle. Maybe use a pointer instead?
I tend to use references when I want to enforce that pointers are not NULL. Tell me If this rubs strongly against webkit tradition - I'll change to pointers.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list