[Webkit-unassigned] [Bug 62345] [V8][Chromium] Use per-isolate embedder data instead of statics for caches in bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62345





--- Comment #4 from Adam Barth <abarth at webkit.org>  2011-06-09 00:46:21 PST ---
(From update of attachment 96525)
View in context: https://bugs.webkit.org/attachment.cgi?id=96525&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2206
> +    V8BindingPerIsolateData::TemplateMap::iterator result = 
> +        data->rawTemplateMap().find(&info);

One line pls.

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2207
> +    if (result != data->rawTemplateMap().end()) {

No { pls

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2210
> +    v8::HandleScope handle_scope;

handle_scope => handleScope

> Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2223
> +    V8BindingPerIsolateData::TemplateMap::iterator result = 
> +        data->templateMap().find(&info);
> +    if (result != data->templateMap().end()) {
> +        return result->second;
> +    }

ditto

> Source/WebCore/bindings/v8/V8Binding.cpp:72
> +    void* data = isolate->GetData();
> +    if (data)
> +        delete static_cast<V8BindingPerIsolateData*>(data);

This pattern is really ugly.

> Source/WebCore/bindings/v8/V8Binding.cpp:595
> +    v8::Persistent<v8::FunctionTemplate>& toStringTemplate = V8BindingPerIsolateData::current()->toStringTemplate();

Using a reference here is very subtle.  Maybe use a pointer instead?

> Source/WebCore/bindings/v8/V8Binding.h:76
> +        V8BindingPerIsolateData(v8::Isolate*);

explicit

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.