[Webkit-unassigned] [Bug 53359] Web Inspector: Allow the console to persist on page refresh or navigation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 9 07:59:30 PDT 2011


--- Comment #6 from Sreeram Ramachandran <sreeram at chromium.org>  2011-06-09 07:59:30 PST ---
(In reply to comment #5)
> > 3. I've added a new "frameNavigated" message just so that the frontend can determine whether to request the backend to clear messages. Is there a way to query the WebInspector.preserveLog property directly from the backend? If so, we could get rid of this message altogether.
> I am not sure there is a need for this. There is a number of frameNavigated signals in the front-end already. We should always clear backend objects (as per Yury's comment above), but conditionally wipe them out on the front-end side. As a result, pre-navigation objects will be "dead" (non-expandable, not pointing to any page instances), but still visible in the UI.

I don't know the implications of not clearing the backend objects. Could you explain why it's important to do so? On first glance, it seems to me to be reasonable to keep them around. Could stuff like "m_previousMessage" lead to problems if the backend and frontend have different lists of messages?

To be clear, my current patch doesn't let you expand dead objects either, so it _appears_ to have no functional difference to clearing the backend objects, but then again, I'm totally new to this part of the code, and I don't know the logic involved.

> I'd suggest that you add a checkbox to the console context menu (the one next to the XHR logging toggle) in order not to mess with the UI challenges for now. I don't see anything wrong with the patch code-wise, but I'll r- it until we figure out the UI bit + object lifetime.

I can certainly implement this, but I'd strongly encourage you to consider a more uniform UI like in the current patch. It seems confusing to have two different ways of achieving the same functionality in two panels (especially if one is a button and the other tucked away in a context menu).

If the icon is the only thing that's confusing, I can try my hand at adding something different. If it's also a matter of other panels not respecting the setting (yet), that should give us more impetus to add similar functionality to those panels as soon as possible. I think it would be fantastic to have all panels implement "preserve log" functionality.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list