[Webkit-unassigned] [Bug 53359] Web Inspector: Allow the console to persist on page refresh or navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53359





--- Comment #7 from Yury Semikhatsky <yurys at chromium.org>  2011-06-09 08:24:37 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > > 3. I've added a new "frameNavigated" message just so that the frontend can determine whether to request the backend to clear messages. Is there a way to query the WebInspector.preserveLog property directly from the backend? If so, we could get rid of this message altogether.
> > 
> > I am not sure there is a need for this. There is a number of frameNavigated signals in the front-end already. We should always clear backend objects (as per Yury's comment above), but conditionally wipe them out on the front-end side. As a result, pre-navigation objects will be "dead" (non-expandable, not pointing to any page instances), but still visible in the UI.
> 
> I don't know the implications of not clearing the backend objects. Could you explain why it's important to do so? On first glance, it seems to me to be reasonable to keep them around.

Not clearing them may prevent garbage collection of potentially all JavaScript objects in the old document, we don't want such leaks.

> Could stuff like "m_previousMessage" lead to problems if the backend and frontend have different lists of messages?
>
Yes, it could. m_previousMessage message from the old document may match a message in the new document.

I agree with Pavel, we shouldn't try to preserve messages on the backend, keeping them in the frontend will be enough for reading their message text. Also, if some messages are preserved after navigation, we should probably mark navigation point in the console log.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.