[Webkit-unassigned] [Bug 53359] Web Inspector: Allow the console to persist on page refresh or navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53359





--- Comment #4 from Sreeram Ramachandran <sreeram at chromium.org>  2011-06-08 15:45:34 PST ---
(In reply to comment #3)
> Created an attachment (id=96495)
 --> (https://bugs.webkit.org/attachment.cgi?id=96495&action=review) [details]
> Patch

Some notes on the above patch:

1. I've moved the "Preserve Log upon Navigation" button to global scope (so the setting is now shared by the Network and Console panels). There might be an expectation that this will also be honoured for other panels (Timeline? Resources?), but currently, it has no effect on them.

2. In the Timeline panel, there's already a similar looking button, which makes for ugly UI, since now both buttons are visible. I'd like to change the glyph of the preserve-log button to something else, but don't have good ideas (perhaps a padlock icon?). Any UI design help would be appreciated!

3. I've added a new "frameNavigated" message just so that the frontend can determine whether to request the backend to clear messages. Is there a way to query the WebInspector.preserveLog property directly from the backend? If so, we could get rid of this message altogether.

4. I couldn't see a simple way to trigger the frameNavigated message in the inspector/protocol/console-agent layout test, so it's currently "not checked".

5. I haven't added any new test for this setting, mainly because I didn't see an existing test covering the current network-panel-only preserveLog setting. Please advise if I should go ahead and add a test anyway (which should cover the usage of this setting by both the Network and Console panels).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.