[Webkit-unassigned] [Bug 62164] Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62164





--- Comment #21 from Dmitry Lomov <dslomov at google.com>  2011-06-07 08:03:42 PST ---
(In reply to comment #14)
> (In reply to comment #12)
> > Created an attachment (id=96189)
 --> (https://bugs.webkit.org/attachment.cgi?id=96189&action=review) [details] [details]
> > Updated threading comment in DOMDataStore.cpp
> > 
> > This patch generates bogus style error (comparison with 0 inside UNLIKELY)
> 
> 1. You could use !!a instead of a != 0.
> 2. More importantly, UNLIKELY only appears to be defined for GCC.
> 
> I think you can get the same result by reversing the if.
> 
> if (!context)
>     return m_defaultStore;
> return *context->world()->domDataStore();
> 
> (You could still add LIKELY here if it was useful.)

I think we should change the style tool to be aware of LIKELY and UNLIKELY.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.