[Webkit-unassigned] [Bug 62164] Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62164





--- Comment #20 from Dmitry Lomov <dslomov at google.com>  2011-06-07 08:02:43 PST ---
(In reply to comment #15)
> (From update of attachment 96189 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96189&action=review
> 
> This looks great.  There's probably another round of cleanup we can do here, but we can do that in a subsequent patch.
> 
> > Source/WebCore/bindings/v8/DOMData.cpp:74
> > +
> > +
> 
> This diff seem unneeded.
> 
> > Source/WebCore/bindings/v8/DOMData.h:54
> > -        virtual DOMDataStore& getStore() = 0;
> > +        DOMDataStore& getStore() { return getMainThreadStore(); }
> 
> Now that this function isn't virtual, it seems like we don't need to separate these calls, right?
> 
> > Source/WebCore/bindings/v8/DOMData.h:62
> > -        ThreadIdentifier owningThread() const { return m_owningThread; }
> > +        static DOMDataStore& getCurrentMainThreadStore() { return getCurrent()->getMainThreadStore(); }
> 
> Do we still need the concept of "MainThreadStore" or can we remove all mentions of that too now?

All this is going to change soon when we will have one isolate per V8IsolatedWorld.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.