[Webkit-unassigned] [Bug 62099] createEvent("PopStateEvent") raises NOT_SUPPORTED_ERR: DOM Exception 9

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62099


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #96053|review?                     |review-
               Flag|                            |




--- Comment #8 from Sam Weinig <sam at webkit.org>  2011-06-05 17:19:44 PST ---
(From update of attachment 96053)
View in context: https://bugs.webkit.org/attachment.cgi?id=96053&action=review

Otherwise it looks fine.  Lets go another round.

> ChangeLog:13
> +
> +        * ../LayoutTests/fast/events/fire-popstate-event-expected.txt: Added.
> +        * ../LayoutTests/fast/events/fire-popstate-event.html: Added.
> +        * ../Source/WebCore/dom/Document.cpp:
> +        * ../Source/WebCore/dom/PopStateEvent.cpp:
> +        * ../Source/WebCore/dom/PopStateEvent.h:

This ChangeLog should not be here. Please use the ones in /Source/WebCore and /LayouTests

> Source/WebCore/dom/PopStateEvent.cpp:36
> +    , m_stateObject()

This line is not necessary, the construction is implicit.

> Source/WebCore/dom/PopStateEvent.h:41
> +    static PassRefPtr<PopStateEvent> create(PassRefPtr<SerializedScriptValue> stateObject);

I don't think the parameter name adds much here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.