[Webkit-unassigned] [Bug 62099] createEvent("PopStateEvent") raises NOT_SUPPORTED_ERR: DOM Exception 9

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=62099





--- Comment #7 from Paul Kinlan <paulkinlan at google.com>  2011-06-05 11:02:45 PST ---
(From update of attachment 96053)
(In reply to comment #5)
> (From update of attachment 96037 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96037&action=review
> 
> Looks pretty good.
> 
> > Source/WebCore/dom/PopStateEvent.cpp:34
> > +PopStateEvent::PopStateEvent()
> 
> You need to call Event's consturctor and initialize m_stateObject

Done

> 
> > Source/WebCore/dom/PopStateEvent.h:40
> > +    static PassRefPtr<PopStateEvent> create()

I was following the guidance from another Event, however I then checked some others and it is inconsistent.  I have moved the implementation to PopStateEvent.cpp for both create's.
> 
> Would slightly prefer these factory methods being moved inside the .cpp
> 
> > Source/WebCore/dom/PopStateEvent.h:54
> > +protected:
> 
> Does anythign sub-class this?  If not, put it inside "private:"
Done.  Given that nothing sub-classes this and it is new for this bug fix it makes sense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.