[Webkit-unassigned] [Bug 61834] Web Inspector: CRASH if Expanding Event Listener on document

Sun Jun 5 14:41:30 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=61834

--- Comment #12 from Joseph Pecoraro <joepeck at webkit.org>  2011-06-05 14:41:30 PST ---
(In reply to comment #11)
> (From update of attachment 96009 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96009&action=review
> 
> The reason I prefer sniffer to the runAfterPendingDispatches is that it tests exactly what I expect. runAfterPendingDispatches is called not after a particular action I am testing, but after its potential implications. Also, it just makes us run more code while in the test (all subsequent updates for styles and such) and hence reduce the test robustness.

In this case, we expand a sidebar, wait for updates, expand each section, wait for multiple updates, expand each event bar, wait for multiple updates, and expand each property tree and wait for multiple updates. The sniffers at the inner levels, would need to use counters to only dispatch the next step after everything has expanded. It seems overly complicated.

Also, if I use sniffers I should probably move the functions out of elements-tests.js, because the functions could no longer be reliably called more than once in a test. This is because the sniffers they add would need to be sticky, which right now can't be easily removed, and if multiple sniffers get added problems could arise.

> > LayoutTests/inspector/elements/event-listener-sidebar.html:27
> > +        function testSetupEventListeners(next)
> 
> You no longer need neither testSetupEventListeners nor the testSuite sequence (just selectNode followed with expandAndDump)
> 
> > LayoutTests/inspector/elements/event-listener-sidebar.html:51
> > +<body onload="runTest()">
> 
> you want onloadHandler call here.

You're absolutely right on both of these. I have no excuse for this blunder. Sorry!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.